Skip to content

Removing the redundant ifup command usage - #3297

Open
PavamanSubramaniyam wants to merge 1 commit into
avocado-framework-tests:masterfrom
PavamanSubramaniyam:removing_ifup_commands
Open

Removing the redundant ifup command usage#3297
PavamanSubramaniyam wants to merge 1 commit into
avocado-framework-tests:masterfrom
PavamanSubramaniyam:removing_ifup_commands

Conversation

@PavamanSubramaniyam

@PavamanSubramaniyam PavamanSubramaniyam commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

ifup and ifdown commands are deprecated in SLES16 and RHEL releases There are avocado utils network bring up functions already being called to bringup the host intefaces which are sufficient

@PavamanSubramaniyam

PavamanSubramaniyam commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Attaching the execution result logs with ifup commands removed from the scripts:

avocado run --max-parallel-tasks=1 rping.py -m rping.py.data/rping_roce.yaml
/usr/local/lib/python3.13/site-packages/avocado/core/init.py:18: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
import pkg_resources
JOB ID : 5bca05076a9701d8d6acd8548e22328fcab425fe
JOB LOG : /root/avocado-fvt-wrapper/results/job-2026-09-03T00.27-5bca050/job.log
(01/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-1500-314d: STARTED
(01/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-1500-314d: PASS (52.22 s)
(02/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-2000-903b: STARTED
(02/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-2000-903b: PASS (53.47 s)
(03/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-3000-6da7: STARTED
(03/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-3000-6da7: PASS (53.46 s)
(04/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-4000-4b00: STARTED
(04/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-4000-4b00: PASS (53.54 s)
(05/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-5000-1db8: STARTED
(05/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-5000-1db8: PASS (53.45 s)
(06/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-6000-b9f1: STARTED
(06/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-6000-b9f1: PASS (53.43 s)
(07/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-7000-e20d: STARTED
(07/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-7000-e20d: PASS (53.43 s)
(08/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-8000-f77b: STARTED
(08/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-8000-f77b: PASS (53.58 s)
(09/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-9000-55eb: STARTED
(09/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-9000-55eb: PASS (53.49 s)
(10/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-1500-38c1: STARTED
(10/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-1500-38c1: PASS (52.23 s)
(11/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-2000-a8db: STARTED
(11/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-2000-a8db: PASS (53.46 s)
(12/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-3000-5e52: STARTED
(12/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-3000-5e52: PASS (53.51 s)
(13/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-4000-5c5f: STARTED
(13/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-4000-5c5f: PASS (53.59 s)
(14/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-5000-a9ac: STARTED
(14/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-5000-a9ac: PASS (53.43 s)
(15/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-6000-56d1: STARTED
(15/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-6000-56d1: PASS (53.51 s)
(16/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-7000-7db9: STARTED
(16/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-7000-7db9: PASS (53.43 s)
(17/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-8000-46c2: STARTED
(17/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-8000-46c2: PASS (53.57 s)
(18/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-9000-23d1: STARTED
(18/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-9000-23d1: PASS (53.60 s)
(19/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-1500-af2a: STARTED
(19/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-1500-af2a: PASS (52.39 s)
(20/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-2000-6d1d: STARTED
(20/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-2000-6d1d: PASS (53.75 s)
(21/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-3000-183c: STARTED
(21/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-3000-183c: PASS (53.56 s)
(22/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-4000-9735: STARTED
(22/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-4000-9735: PASS (53.71 s)
(23/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-5000-801e: STARTED
(23/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-5000-801e: PASS (53.66 s)
(24/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-6000-ce9a: STARTED
(24/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-6000-ce9a: PASS (53.62 s)
(25/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-7000-b18f: STARTED
(25/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-7000-b18f: PASS (53.66 s)
(26/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-8000-1c48: STARTED
(26/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-8000-1c48: PASS (53.75 s)
(27/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-9000-46c1: STARTED
(27/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-9000-46c1: PASS (53.71 s)
RESULTS : PASS 27 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2026-09-03T00.27-5bca050/results.html
JOB TIME : 1498.64 s

@PavamanSubramaniyam

PavamanSubramaniyam commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Complete result logs are attached to the corresponding Jira task.

Naresh-ibm
Naresh-ibm reviewed Sep 4, 2026
View reviewed changes
Comment thread io/net/infiniband/rping.py
@Naresh-ibm Naresh-ibm self-assigned this Sep 4, 2026
@PavamanSubramaniyam
Removing the redundant ifup command usage
2624467 
ifup and ifdown commands are deprecated in SLES16 and RHEL releases
There are avocado utils network bring up functions already being
called to bringup the host intefaces which are sufficient

Signed-off-by: Pavaman Subramaniyam <pavsubra@linux.vnet.ibm.com>
@PavamanSubramaniyam

PavamanSubramaniyam commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

I have again executed the tests after addressing the review comments.

avocado run --max-parallel-tasks=1 rping.py -m rping.py.data/rping_roce.yaml
/usr/local/lib/python3.13/site-packages/avocado/core/init.py:18: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
import pkg_resources
JOB ID : 17e78b70b2f1b0041277bda9b40604c150e824dc
JOB LOG : /root/avocado-fvt-wrapper/results/job-2026-09-05T01.20-17e78b7/job.log
(01/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-1500-18b5: STARTED
(01/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-1500-18b5: PASS (52.38 s)
(02/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-2000-02e0: STARTED
(02/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-2000-02e0: PASS (53.48 s)
(03/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-3000-457d: STARTED
(03/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-3000-457d: PASS (53.36 s)
(04/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-4000-b1d5: STARTED
(04/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-4000-b1d5: PASS (53.47 s)
(05/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-5000-9e8f: STARTED
(05/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-5000-9e8f: PASS (53.44 s)
(06/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-6000-9fc0: STARTED
(06/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-6000-9fc0: PASS (53.48 s)
(07/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-7000-9836: STARTED
(07/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-7000-9836: PASS (53.38 s)
(08/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-8000-98d1: STARTED
(08/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-8000-98d1: PASS (53.47 s)
(09/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-9000-dfd6: STARTED
(09/27) rping.py:Rping.test;run-Parameters-Test-options-first-mtu-9000-dfd6: PASS (53.43 s)
(10/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-1500-55ec: STARTED
(10/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-1500-55ec: PASS (52.18 s)
(11/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-2000-f2cf: STARTED
(11/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-2000-f2cf: PASS (53.50 s)
(12/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-3000-40ef: STARTED
(12/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-3000-40ef: PASS (53.47 s)
(13/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-4000-c092: STARTED
(13/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-4000-c092: PASS (53.51 s)
(14/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-5000-4097: STARTED
(14/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-5000-4097: PASS (53.51 s)
(15/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-6000-87b9: STARTED
(15/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-6000-87b9: PASS (53.57 s)
(16/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-7000-a42e: STARTED
(16/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-7000-a42e: PASS (53.47 s)
(17/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-8000-79cf: STARTED
(17/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-8000-79cf: PASS (53.65 s)
(18/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-9000-dce1: STARTED
(18/27) rping.py:Rping.test;run-Parameters-Test-options-second-mtu-9000-dce1: PASS (53.61 s)
(19/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-1500-6edd: STARTED
(19/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-1500-6edd: PASS (52.44 s)
(20/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-2000-ce50: STARTED
(20/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-2000-ce50: PASS (53.58 s)
(21/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-3000-720e: STARTED
(21/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-3000-720e: PASS (53.70 s)
(22/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-4000-3ad1: STARTED
(22/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-4000-3ad1: PASS (53.71 s)
(23/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-5000-99a1: STARTED
(23/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-5000-99a1: PASS (53.71 s)
(24/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-6000-af2a: STARTED
(24/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-6000-af2a: PASS (53.74 s)
(25/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-7000-5509: STARTED
(25/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-7000-5509: PASS (53.75 s)
(26/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-8000-c15a: STARTED
(26/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-8000-c15a: PASS (53.81 s)
(27/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-9000-22c0: STARTED
(27/27) rping.py:Rping.test;run-Parameters-Test-options-third-mtu-9000-22c0: PASS (53.77 s)
RESULTS : PASS 27 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2026-09-05T01.20-17e78b7/results.html
JOB TIME : 1498.35 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naresh-ibm Naresh-ibm Naresh-ibm left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Naresh-ibm Naresh-ibm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PavamanSubramaniyam @Naresh-ibm